Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #890 - use setting name as attribute name #1383

Conversation

cli1005
Copy link
Contributor

@cli1005 cli1005 commented Mar 29, 2022

What

In preferences, use setting name as attribute name
More details in : #890 (comment)

Screenshot

Simulator Screen Shot - iPhone 13 - 2022-03-29 at 13 36 37

Fixes bug(s)

Part of

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @cli1005

@teolemon
Copy link
Member

thanks @cli1005 , merging and releasing to internal 👍

@teolemon teolemon merged commit 060dbc2 into openfoodfacts:develop Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use attribute setting_name (e.g. "Low salt") instead of name ("Salt") in preferences menu
3 participants